Display only manually added my company tags on topology screens #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@4bf2e39 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
tests please :) |
|
@ohadlevy this is being tested in the model, see the linked PR above... |
|
btw: off topic - is there an easy way to zoom into the topology view? while looking at https://github.com/ansible/awx I saw they have something similar that represent workflows that you can zoom into and take actions in that context, maybe worth looking into that |
|
@ohadlevy work in progress patternfly/angular-patternfly#633 |
|
@miq-bot remove_label pending core |
simaishi
pushed a commit
that referenced
this pull request
Dec 14, 2017
Display only manually added my company tags on topology screens (cherry picked from commit da363ba) https://bugzilla.redhat.com/show_bug.cgi?id=1526049
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the JSON for a topology, all the related tags are being fetched. This is a problem as we don't want to expose internal tags in the UI. As a 🎄 🎁 @lpichler added a new method into
ActsAsTaggablethat fetches only the tags we need.Before:
After:
@miq-bot add_label topology, bug, pending core, gaprindashvili/yes
https://bugzilla.redhat.com/show_bug.cgi?id=1519457