miq_token - move API auth from sessionStorage to localStorage #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sessionStorage is tab-local, so new browser tabs opened from manageiq now immediately log off (since we started logging off on API authentication failures) To fix this, moving `miq_token` to `localStorage` which is persistent. (Note: this also means the token won't be forgotten on closing the tab, and may still be used until it expires on the backend.)
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/8b4a336873d8362bb683adc1f31fdf0c68533c37 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 app/controllers/dashboard_controller.rb
|
|
@miq-bot remove_label bugzilla needed |
|
Verified this fixes the issue in the UI. |
simaishi
pushed a commit
that referenced
this pull request
Jan 3, 2018
miq_token - move API auth from sessionStorage to localStorage (cherry picked from commit 1461256) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530783
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sessionStorage is tab-local, so new browser tabs opened from manageiq now immediately log off (since we started logging off on API authentication failures - #2715)
To fix this, moving
miq_tokentolocalStoragewhich is persistent.(Note: this also means the token won't be forgotten on closing the tab, and may still be used until it expires on the backend, there should be no change in visibility though.)
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1528326
Cc @martinpovolny, @abellotti
Testing:
Before:
the new tab immediately goes to the login screen
After:
the link is opened in the new tab