Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables Save button when the SmartState Docker EC2 form is valid #3070

Merged
merged 5 commits into from
Dec 19, 2017
Merged

Enables Save button when the SmartState Docker EC2 form is valid #3070

merged 5 commits into from
Dec 19, 2017

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Dec 14, 2017 •
edited
Loading

Adjustments around the new SmartState Docker for EC2.

Includes -

  • Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1525515, which enables the Save button
  • Removes provider-specific code in _form_buttons_verify_angular.html.haml, to keep it generic
  • Provisions for a use case where Validation button should not be rendered (like the SmartState Docker case)

@AparnaKarve
Copy link
Contributor Author

@miq-bot add_label bug,gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Dec 14, 2017

Checked commits AparnaKarve/manageiq-ui-classic@6093335~...686aadb with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 2 offenses detected

app/views/layouts/angular-bootstrap/_auth_credentials_angular_bootstrap.html.haml

  • ⚠️ - Line 76 - Prefer to_s over string interpolation.
  • ⚠️ - Line 76 - Prefer to_s over string interpolation.

@AparnaKarve
Copy link
Contributor Author

@jerryk55 Can you test this?

@dclarizio dclarizio self-assigned this Dec 19, 2017
@h-kataria
Copy link
Contributor

verified in UI, works!

@dclarizio dclarizio merged commit a83ab23 into ManageIQ:master Dec 19, 2017
@dclarizio dclarizio added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 19, 2017
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit f1c5c56d72bbe3903eea65385732734ba36f5886
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Tue Dec 19 13:53:26 2017 -0800

    Merge pull request #3070 from AparnaKarve/bz1525515_fix_save_with_amz_ss_docker_in_the_picture
    
    Enables Save button when the SmartState Docker EC2 form is valid
    (cherry picked from commit a83ab23adfa185ff67d1f976914ae84c1644c2d4)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530763

@AparnaKarve AparnaKarve deleted the bz1525515_fix_save_with_amz_ss_docker_in_the_picture branch January 3, 2018 18:17
simaishi pushed a commit that referenced this pull request Jan 3, 2018
@simaishi
Merge pull request #3070 from AparnaKarve/bz1525515_fix_save_with_amz…
f1c5c56 
…_ss_docker_in_the_picture

Enables Save button when the SmartState Docker EC2 form is valid
(cherry picked from commit a83ab23)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
bug compute/cloud gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AparnaKarve @miq-bot @h-kataria @simaishi @dclarizio