Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the not implemented recent alerts screen #3091

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Hide the not implemented recent alerts screen #3091

merged 1 commit into from
Dec 19, 2017

Conversation

moolitayer
Copy link

@moolitayer moolitayer commented Dec 18, 2017 •
edited
Loading

@moolitayer
Copy link
Author

@miq-bot add_label gaprindashvili/yes, bug

@miq-bot
Copy link
Member

miq-bot commented Dec 18, 2017

Checked commit moolitayer@3e214c6 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@moolitayer
Copy link
Author

@yaacov @elad661 please review

elad661
elad661 approved these changes Dec 18, 2017
View reviewed changes
Copy link
Contributor

@elad661 elad661 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

yaacov
yaacov approved these changes Dec 18, 2017
View reviewed changes
Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzazrivec mzazrivec self-assigned this Dec 19, 2017
@mzazrivec mzazrivec added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 19, 2017
@mzazrivec mzazrivec merged commit d0ace8d into ManageIQ:master Dec 19, 2017
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit 720d1bd22e8dcfbdcbb0ff20bd0818297b4f01aa
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Dec 19 15:38:37 2017 +0100

    Merge pull request #3091 from moolitayer/hide_recent_alerts_screen
    
    Hide the not implemented recent alerts screen
    (cherry picked from commit d0ace8dd8fd0db45dbf3a00ac4f1735685215a43)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1530757

simaishi pushed a commit that referenced this pull request Jan 3, 2018
@mzazrivec @simaishi
Merge pull request #3091 from moolitayer/hide_recent_alerts_screen
720d1bd 
Hide the not implemented recent alerts screen
(cherry picked from commit d0ace8d)

https://bugzilla.redhat.com/show_bug.cgi?id=1530757
@GilbertCherrie GilbertCherrie mentioned this pull request Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elad661 elad661 elad661 approved these changes

@yaacov yaacov yaacov approved these changes

@martinpovolny martinpovolny Awaiting requested review from martinpovolny

Assignees

@mzazrivec mzazrivec

Labels
bug compute/containers gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@moolitayer @miq-bot @simaishi @elad661 @yaacov @mzazrivec