Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the "Policy" word translatable by putting it into a gettext fn. #3113

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Make the "Policy" word translatable by putting it into a gettext fn. #3113

merged 1 commit into from
Dec 19, 2017

Conversation

mzazrivec
Copy link
Contributor

@miq-bot
Copy link
Member

miq-bot commented Dec 19, 2017

Checked commit mzazrivec@a7562e6 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@martinpovolny martinpovolny self-assigned this Dec 19, 2017
@martinpovolny martinpovolny added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 19, 2017
@martinpovolny martinpovolny merged commit 118fc53 into ManageIQ:master Dec 19, 2017
simaishi pushed a commit that referenced this pull request Jan 3, 2018
@martinpovolny @simaishi
Merge pull request #3113 from mzazrivec/make_policy_word_translatable
0d5ea92 
Make the "Policy" word translatable by putting it into a gettext fn.
(cherry picked from commit 118fc53)

https://bugzilla.redhat.com/show_bug.cgi?id=1530760
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit 0d5ea92586411ba626280289df54186de506e30d
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Tue Dec 19 20:00:50 2017 +0100

    Merge pull request #3113 from mzazrivec/make_policy_word_translatable
    
    Make the "Policy" word translatable by putting it into a gettext fn.
    (cherry picked from commit 118fc533cb1e6ad64cd138db8fc4ca8fc301e6de)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1530760

@mzazrivec mzazrivec mentioned this pull request Jan 9, 2018
Merged
@mzazrivec mzazrivec deleted the make_policy_word_translatable branch February 22, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
bug control gaprindashvili/backported internationalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzazrivec @miq-bot @simaishi @martinpovolny