Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topology: Fix second search #313

Merged
merged 1 commit into from
Feb 8, 2017
Merged

Topology: Fix second search #313

merged 1 commit into from
Feb 8, 2017

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Feb 7, 2017 •
edited
Loading

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1415472

Topology nodes opacity has to be reset before performing next search so that new results won't be a subset of previous results.

@zakiva
Copy link
Contributor Author

zakiva commented Feb 7, 2017

@miq-bot add_label topology, bug

@miq-bot
Copy link
Member

miq-bot commented Feb 7, 2017

@zakiva Cannot apply the following label because they are not recognized: topology

@miq-bot miq-bot added the bug label Feb 7, 2017
@miq-bot
Copy link
Member

miq-bot commented Feb 7, 2017

Checked commit zakiva@b5b6d9f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍰

@zakiva
Copy link
Contributor Author

zakiva commented Feb 7, 2017

@simon3z @zeari @martinpovolny Please review

@mzazrivec mzazrivec self-assigned this Feb 8, 2017
@mzazrivec mzazrivec added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 8, 2017
@mzazrivec mzazrivec merged commit b6aac44 into ManageIQ:master Feb 8, 2017
@simaishi
Copy link
Contributor

simaishi commented Mar 3, 2017

Euwe backport (to manageiq repo) details:

$ git log -1
commit fbb783830e30cb68b6bb6bf890a641ac85b6333a
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Wed Feb 8 10:34:41 2017 +0100

    Merge pull request #313 from zakiva/fix_topology_search
    
    Topology: Fix second search
    (cherry picked from commit b6aac445e4ea36eeeb6a18fabada57bc618b1308)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1420467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zakiva @miq-bot @simaishi @mzazrivec