-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in get_view_where_clause #3155
Merged
mzazrivec
merged 1 commit into
ManageIQ:master
from
PanSpagetka:fix-group-by-tag-show-runnin-vms
Jan 4, 2018
Merged
Fix typo in get_view_where_clause #3155
mzazrivec
merged 1 commit into
ManageIQ:master
from
PanSpagetka:fix-group-by-tag-show-runnin-vms
Jan 4, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanSpagetka
force-pushed
the
fix-group-by-tag-show-runnin-vms
branch
from
January 3, 2018 14:57
0e1224c
to
655e1a1
Compare
Checked commit PanSpagetka@655e1a1 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jan 5, 2018
…n-vms Fix typo in get_view_where_clause (cherry picked from commit 8bcc3d3) https://bugzilla.redhat.com/show_bug.cgi?id=1531614 https://bugzilla.redhat.com/show_bug.cgi?id=1531616 https://bugzilla.redhat.com/show_bug.cgi?id=1531617
Gaprindashvili backport details:
|
simaishi
pushed a commit
that referenced
this pull request
Jan 10, 2018
…n-vms Fix typo in get_view_where_clause (cherry picked from commit 8bcc3d3) https://bugzilla.redhat.com/show_bug.cgi?id=1531615 https://bugzilla.redhat.com/show_bug.cgi?id=1531618 https://bugzilla.redhat.com/show_bug.cgi?id=1531619
Fine backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo in
get_view_where_clause
. Chart code is shared for all entities, so it fixes all three BZs.Title and text in the chart menu is still wrong, but since it is blocker, it could be fixed in separate PR.
Links [Optional]
https://bugzilla.redhat.com/show_bug.cgi?id=1530208
https://bugzilla.redhat.com/show_bug.cgi?id=1530296
https://bugzilla.redhat.com/show_bug.cgi?id=1530226
Screenshots