Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in get_view_where_clause #3155

Merged

Conversation

PanSpagetka
Copy link
Contributor

@PanSpagetka PanSpagetka commented Jan 3, 2018

Fix typo in get_view_where_clause. Chart code is shared for all entities, so it fixes all three BZs.
Title and text in the chart menu is still wrong, but since it is blocker, it could be fixed in separate PR.

Links [Optional]

https://bugzilla.redhat.com/show_bug.cgi?id=1530208
https://bugzilla.redhat.com/show_bug.cgi?id=1530296
https://bugzilla.redhat.com/show_bug.cgi?id=1530226

Screenshots

screencast from 2018-01-03 15-49-19
screencast from 2018-01-03 16-02-06

@PanSpagetka PanSpagetka changed the title Fix typo Fix typo in get_view_where_clause Jan 3, 2018
@PanSpagetka PanSpagetka force-pushed the fix-group-by-tag-show-runnin-vms branch from 0e1224c to 655e1a1 Compare January 3, 2018 14:57
@miq-bot
Copy link
Member

miq-bot commented Jan 3, 2018

Checked commit PanSpagetka@655e1a1 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this Jan 4, 2018
@mzazrivec mzazrivec added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 4, 2018
@mzazrivec mzazrivec merged commit 8bcc3d3 into ManageIQ:master Jan 4, 2018
@simaishi
Copy link
Contributor

simaishi commented Jan 5, 2018

Gaprindashvili backport details:

$ git log -1
commit f6593c38deb00f10f4fb80dce3bad1d6d91d7197
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Jan 4 12:06:26 2018 +0100

    Merge pull request #3155 from PanSpagetka/fix-group-by-tag-show-runnin-vms
    
    Fix typo in get_view_where_clause
    (cherry picked from commit 8bcc3d39193f8b4ac7c0c06d92e0d45cf677cd2c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1531614
    https://bugzilla.redhat.com/show_bug.cgi?id=1531616
    https://bugzilla.redhat.com/show_bug.cgi?id=1531617

@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit c97f139c98ace77b86a3fcea34e23bff9f8f1c69
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Jan 4 12:06:26 2018 +0100

    Merge pull request #3155 from PanSpagetka/fix-group-by-tag-show-runnin-vms
    
    Fix typo in get_view_where_clause
    (cherry picked from commit 8bcc3d39193f8b4ac7c0c06d92e0d45cf677cd2c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1531615
    https://bugzilla.redhat.com/show_bug.cgi?id=1531618
    https://bugzilla.redhat.com/show_bug.cgi?id=1531619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants