Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of font icons on summary screens #3158

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Fix alignment of font icons on summary screens #3158

merged 1 commit into from
Jan 3, 2018

Conversation

epwinchell
Copy link
Contributor

This PR adjusts the width of font icons in the summary screen tables so that text to the right is properly aligned. It also syncs the alignment of the font icons with the SVGs.

https://bugzilla.redhat.com/show_bug.cgi?id=1528182

screen shot 2018-01-03 at 1 56 52 pm

screen shot 2018-01-03 at 1 41 04 pm

@epwinchell
Copy link
Contributor Author

@miq-bot add_label bug, formatting/styling

@epwinchell
Copy link
Contributor Author

@miq-bot assign @dclarizio

@miq-bot
Copy link
Member

miq-bot commented Jan 3, 2018

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/91e059f8b2f1b97881eb54666c8ec7729480db1a with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@dclarizio dclarizio merged commit f504a34 into ManageIQ:master Jan 3, 2018
@dclarizio dclarizio added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 3, 2018
simaishi pushed a commit that referenced this pull request Jan 4, 2018
 Fix alignment of font icons on summary screens
(cherry picked from commit f504a34)

https://bugzilla.redhat.com/show_bug.cgi?id=1531310
@simaishi
Copy link
Contributor

simaishi commented Jan 4, 2018

Gaprindashvili backport details:

$ git log -1
commit f7395547ab2342886ad8de718b5bbcdd42172f9f
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Wed Jan 3 12:53:27 2018 -0800

    Merge pull request #3158 from epwinchell/1528182
    
     Fix alignment of font icons on summary screens
    (cherry picked from commit f504a3495c38199e50a27bf361b047620d715f44)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1531310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants