Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Provider timelines button fix. #316

Merged

Conversation

h-kataria
Copy link
Contributor

Changed timelines button to send up an AJAX transaction similar to other areas in the product and added Timeline data availability check around the button to be consistent.

https://bugzilla.redhat.com/show_bug.cgi?id=1419908

@dclarizio please review.

Changed timelines button to send up an AJAX transaction similar to other areas in the product and added Timeline data availability check around the button to be consistent.

https://bugzilla.redhat.com/show_bug.cgi?id=1419908
@miq-bot
Copy link
Member

miq-bot commented Feb 7, 2017

Checked commit h-kataria@2131ee0 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

@dclarizio dclarizio self-assigned this Feb 7, 2017
@dclarizio dclarizio merged commit caab6e8 into ManageIQ:master Feb 7, 2017
@dclarizio dclarizio added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 7, 2017
@h-kataria h-kataria deleted the ems_network_timelines_button_fix branch March 2, 2017 14:25
@simaishi
Copy link
Contributor

simaishi commented Mar 3, 2017

Euwe backport (to manageiq repo) details:

$ git log -1
commit 8bf75c20d340ddc7613fdee2de8503befd0ae963
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Tue Feb 7 12:51:52 2017 -0800

    Merge pull request #316 from h-kataria/ems_network_timelines_button_fix
    
    Network Provider timelines button fix.
    (cherry picked from commit caab6e81f64f8e36da8cc0664742aeca527d2aae)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1421161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants