Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing RBAC checks to Add New Cloud Router form #3170

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Jan 5, 2018

screen shot 2018-01-05 at 11 36 03

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1520657

Steps for Testing/QA

For testing can be used RBAC filtering with tagging objects as well.

@miq-bot add_label gaprindashvili/yes, bug

@miq-bot assign @martinpovolny

@lpichler
Copy link
Contributor Author

lpichler commented Jan 5, 2018

@miq-bot add_label blocker

@miq-bot
Copy link
Member

miq-bot commented Jan 5, 2018

Checked commit lpichler@3ebda29 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@martinpovolny martinpovolny added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 5, 2018
@martinpovolny
Copy link
Member

Travis failure is unrelated.

@martinpovolny martinpovolny merged commit c9f9e16 into ManageIQ:master Jan 5, 2018
@lpichler lpichler deleted the add_missing_rbac_check_to_new_cloud_form branch January 5, 2018 12:38
simaishi pushed a commit that referenced this pull request Jan 5, 2018
…cloud_form

Add missing RBAC checks to Add New Cloud Router form
(cherry picked from commit c9f9e16)

https://bugzilla.redhat.com/show_bug.cgi?id=1530800
@simaishi
Copy link
Contributor

simaishi commented Jan 5, 2018

Gaprindashvili backport details:

$ git log -1
commit f5bc31462192c90bb4727fd9ff8fc97934b5d175
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Fri Jan 5 13:29:29 2018 +0100

    Merge pull request #3170 from lpichler/add_missing_rbac_check_to_new_cloud_form
    
    Add missing RBAC checks to Add New Cloud Router form
    (cherry picked from commit c9f9e162fbfa235226271f527751d979dd087e04)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1530800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants