-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show flash message when "Submit" button is pressed. #3198
Show flash message when "Submit" button is pressed. #3198
Conversation
@lgalis can you please test/review. @martinpovolny changed reverse_merge on both lines here to reverse_merge!, having reverse_merge was not setting any default options in |
9e8101d
to
9d621a1
Compare
Removed code to show flash message while options are being selected, should only show flash message for missing options after submit button is pressed. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531462
9d621a1
to
77efd28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tested in the UI.
I did find an unrelated issue - the VM is not cleared when the target type changes - we could make that change as part of this PR or a separate one.
@lgalis addressed your comment, please re-review. |
@h-kataria looks good, the only small thing, also not related to your changes -the dropdown list for vms ( @sb[:vms] also needs to be cleared when changing the filter_type, except for 'all vms' |
4e86f2d
to
148b4fa
Compare
@lgalis addressed your latest comment. |
148b4fa
to
4a37036
Compare
Checked commits h-kataria/manageiq-ui-classic@5c6f1ee~...4a37036 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@h-kataria - looks good, tested in the UI |
…e_fix Show flash message when "Submit" button is pressed. (cherry picked from commit 86854e0) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533514
Gaprindashvili backport details:
|
Removed code to show flash message while options are being selected, should only show flash message for missing options after submit button is pressed.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531462