-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Cloud credentials only when those were selected. #3221
Show Cloud credentials only when those were selected. #3221
Conversation
5013d08
to
ea20d46
Compare
Checked commit h-kataria@ea20d46 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/helpers/service_helper/textual_summary_spec.rb
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified in the UI that the Cloud credentials are not displayed in the summary if they are not selected.
There is another issue mentioned in the BZ - the fact that the last added machine credential is used in a provisioned service - I was not able to verify this issue yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cloud credential row is no longer shown in the summary screen if it is not selected.
The other issue mentioned in the BZ is not reproduceable - so looks good.
…n_service_summary Show Cloud credentials only when those were selected. (cherry picked from commit acd6a9b) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533923
Gaprindashvili backport details:
|
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533109
@lgalis please test
before:
after: