Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Cloud credentials only when those were selected. #3221

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Jan 10, 2018

@h-kataria h-kataria force-pushed the credential_info_display_fix_on_service_summary branch from 5013d08 to ea20d46 Compare January 10, 2018 19:23
@miq-bot
Copy link
Member

miq-bot commented Jan 10, 2018

Checked commit h-kataria@ea20d46 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 5 offenses detected

spec/helpers/service_helper/textual_summary_spec.rb

Copy link
Contributor

@lgalis lgalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified in the UI that the Cloud credentials are not displayed in the summary if they are not selected.

There is another issue mentioned in the BZ - the fact that the last added machine credential is used in a provisioned service - I was not able to verify this issue yet.

Copy link
Contributor

@lgalis lgalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cloud credential row is no longer shown in the summary screen if it is not selected.

The other issue mentioned in the BZ is not reproduceable - so looks good.

@dclarizio dclarizio merged commit acd6a9b into ManageIQ:master Jan 11, 2018
@dclarizio dclarizio added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 11, 2018
simaishi pushed a commit that referenced this pull request Jan 12, 2018
…n_service_summary

Show Cloud credentials only when those were selected.
(cherry picked from commit acd6a9b)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533923
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 812b96d5fd2aa5806025608b66614b2fa53bda43
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Thu Jan 11 08:36:08 2018 -0800

    Merge pull request #3221 from h-kataria/credential_info_display_fix_on_service_summary
    
    Show Cloud credentials only when those were selected.
    (cherry picked from commit acd6a9bb58d387defd67e4f12ead92314d25b7ac)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533923

@h-kataria h-kataria deleted the credential_info_display_fix_on_service_summary branch January 12, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants