Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breadcrumb when navigating to service's ansible credential #3249

Merged
merged 1 commit into from
Jan 17, 2018
Merged

Fix breadcrumb when navigating to service's ansible credential #3249

merged 1 commit into from
Jan 17, 2018

Conversation

mzazrivec
Copy link
Contributor

  1. Create Ansible catalog item and provision it
  2. Navigate to Services -> My Services -> [your service from above]
  3. Navigate to Services -> Requests -> Click on some request
  4. Navigate to Services -> My Services -> [your service from above should be selected]
  5. Click on Provioning tab
  6. Click on the ansible credential resource rendered in the textual summary

Before:
breadcrumb-before

After:
breadcrumb-after

https://bugzilla.redhat.com/show_bug.cgi?id=1533071

@miq-bot miq-bot removed the wip label Jan 15, 2018
@mzazrivec mzazrivec force-pushed the fix_breadcrumbs_when_navigating_to_services_ansible_credential branch from 4d2bbbf to 707985a Compare January 15, 2018 15:45
@miq-bot
Copy link
Member

miq-bot commented Jan 15, 2018

Checked commit mzazrivec@707985a with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

skateman
skateman approved these changes Jan 16, 2018
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval
@martinpovolny please merge

@martinpovolny martinpovolny merged commit 73b1c27 into ManageIQ:master Jan 17, 2018
@martinpovolny martinpovolny self-assigned this Jan 17, 2018
@martinpovolny martinpovolny added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 17, 2018
simaishi pushed a commit that referenced this pull request Jan 19, 2018
@martinpovolny @simaishi
Merge pull request #3249 from mzazrivec/fix_breadcrumbs_when_navigati…
82d3ea4 
…ng_to_services_ansible_credential

Fix breadcrumb when navigating to service's ansible credential
(cherry picked from commit 73b1c27)

https://bugzilla.redhat.com/show_bug.cgi?id=1536519
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 82d3ea4d2d58bf94d58530b772080574edff296e
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Wed Jan 17 11:04:43 2018 +0100

    Merge pull request #3249 from mzazrivec/fix_breadcrumbs_when_navigating_to_services_ansible_credential
    
    Fix breadcrumb when navigating to service's ansible credential
    (cherry picked from commit 73b1c27b3338e95fd2c30b6332024c5c62ba264c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1536519

@mzazrivec mzazrivec deleted the fix_breadcrumbs_when_navigating_to_services_ansible_credential branch February 22, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@martinpovolny martinpovolny

Labels
blocker bug gaprindashvili/backported services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mzazrivec @miq-bot @simaishi @skateman @martinpovolny