Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container node: add dialog_load and related routes. #3263

Merged
merged 1 commit into from
Jan 17, 2018
Merged

Container node: add dialog_load and related routes. #3263

merged 1 commit into from
Jan 17, 2018

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny added this to the bug milestone Jan 17, 2018
@martinpovolny martinpovolny removed this from the bug milestone Jan 17, 2018
@himdel himdel mentioned this pull request Jan 17, 2018
Merged
@miq-bot
Copy link
Member

miq-bot commented Jan 17, 2018

Checked commit martinpovolny@ef02c28 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@ZitaNemeckova
Copy link
Contributor

Tested in UI. No longer Missing route error after clicking custom button with a dialog. Dialog is correctly displayed. LGTM 👍

@dclarizio dclarizio assigned dclarizio and unassigned ZitaNemeckova Jan 17, 2018
@h-kataria h-kataria added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 17, 2018
@h-kataria h-kataria merged commit afed3ca into ManageIQ:master Jan 17, 2018
simaishi pushed a commit that referenced this pull request Jan 17, 2018
@h-kataria @simaishi
Merge pull request #3263 from martinpovolny/dialog_load_route_node
2034ebe 
Container node: add dialog_load and related routes.
(cherry picked from commit afed3ca)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1535633
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 2034ebecaecce6c5e944259ef822d494cbade730
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Wed Jan 17 13:07:37 2018 -0500

    Merge pull request #3263 from martinpovolny/dialog_load_route_node
    
    Container node: add dialog_load and related routes.
    (cherry picked from commit afed3ca0b934dd9958c8a867751ee8b78214fc74)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1535633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
blocker bug compute/containers gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@martinpovolny @miq-bot @ZitaNemeckova @simaishi @dclarizio @h-kataria