Add line breaks below the Role Access dropdown in the Generic Object Definition CustomButton form #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives enough space for the dropdown to display all it's items https://bugzilla.redhat.com/show_bug.cgi?id=1534960
|
@miq-bot add_label formatting/styling,bug,gaprindashvili/yes |
|
/cc @epwinchell |
|
Checked commit AparnaKarve@268e28e with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@martinpovolny Looks fine. |
|
@miq-bot assign @martinpovolny |
simaishi
pushed a commit
that referenced
this pull request
Mar 7, 2018
…oleaccess_dropdown Add line breaks below the Role Access dropdown in the Generic Object Definition CustomButton form (cherry picked from commit 103aeb7) https://bugzilla.redhat.com/show_bug.cgi?id=1552737
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The below BZ describes a partial rendering issue in the bootstrap switch when the page is zoomed out.
The real issue however, is that the 'Role Access' dropdown that is at the end of the page, does not have enough room to expand.
To resolve this, line breaks were added at the end, allowing the dropdown to display it's contents without the user having to zoom out the screen or scroll inside the dropdown.
https://bugzilla.redhat.com/show_bug.cgi?id=1534960
Before (
<By Role>not visible in the dropdown) -After (
<By Role>visible in the dropdown) -