Fixed variable name #3323
Merged
Fixed variable name #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
force-pushed
the
fix_method_and_instance_delete
branch
from
d3cb329
to
cb6edf2
Compare
- Fixed name of variable that is being pushed into aeinstances and aemethods arrays respectively. In both occurrences item[1] was being reset by item = find_xxx command. - Added spec test to verify that both instance and method delete is successful from both list view and detail screens. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1532340
h-kataria
force-pushed
the
fix_method_and_instance_delete
branch
from
cb6edf2
to
d49b403
Compare
|
Checked commit h-kataria@d49b403 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Mar 7, 2018
Fixed variable name (cherry picked from commit b674d57) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552741
|
Gaprindashvili backport details: |
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Mar 8, 2018
Fixes spec test failure cause by backport of ManageIQ#3323 need to use compressed id on Gaprindashvili branch Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552741
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Mar 8, 2018
Fixes spec test failure cause by backport of ManageIQ#3323 need to use compressed id on Gaprindashvili branch Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552741
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Mar 8, 2018
Fixes spec test failure cause by backport of ManageIQ#3323 need to use compressed id on Gaprindashvili branch Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed name of variable that is being pushed into aeinstances and aemethods arrays respectively. In both occurrences item[1] was being reset by item = find_xxx command.
Added spec test to verify that both instance and method delete is successful from both list view and detail screens.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1532340
@mkanoor please test/review.