-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable cloud network editing and deletion for list view. #3349
Disable cloud network editing and deletion for list view. #3349
Conversation
Network editing is only implemented for OpenStack. So it needs to be disabled for the general case. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539723
Checked commit martinpovolny@e07f1cd with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disable cloud network editing and deletion for list view. (cherry picked from commit a025a28) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540755
Gaprindashvili backport details:
|
@martinpovolny I need to understand better this PR here, did we completely removed it from list view? Because even if an action does not apply to all Objects, we should be able to do multi-select and just report in flash message what does not apply.. |
Disable cloud network editing and deletion for list view. (cherry picked from commit a025a28) https://bugzilla.redhat.com/show_bug.cgi?id=1544488
Fine backport details:
|
Network editing is only implemented for OpenStack. So it needs to be
disabled for the general case.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539723
@miq-bot add_label gaprindashvili/yes
@miq-bot add_label bug
@miq-bot add_label networks