Disable cloud network editing and deletion for list view. #3349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Network editing is only implemented for OpenStack. So it needs to be disabled for the general case. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539723
|
Checked commit martinpovolny@e07f1cd with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jan 31, 2018
Disable cloud network editing and deletion for list view. (cherry picked from commit a025a28) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540755
|
Gaprindashvili backport details: |
|
@martinpovolny I need to understand better this PR here, did we completely removed it from list view? Because even if an action does not apply to all Objects, we should be able to do multi-select and just report in flash message what does not apply.. |
simaishi
pushed a commit
that referenced
this pull request
Apr 23, 2018
Disable cloud network editing and deletion for list view. (cherry picked from commit a025a28) https://bugzilla.redhat.com/show_bug.cgi?id=1544488
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network editing is only implemented for OpenStack. So it needs to be
disabled for the general case.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539723
@miq-bot add_label gaprindashvili/yes
@miq-bot add_label bug
@miq-bot add_label networks