Add to providers for toolbar and use it to resolve promise from toolbarClick

[karelhala]

Fixes #3348

When clicking on toolbar items which does not return promise UI console would throw error which was silenced with reload of page. This PR wrap return object in $q.resolve() which works for checking if the return value of miqToolbarOnClick is really promise like object. If not, TOOLBAR_CLICK_FINISH is still sent from toolbarController (it will be sent emediately no need to wait for promise reolve).

UI changes

none

BZ

https://bugzilla.redhat.com/show_bug.cgi?id=1530939

[karelhala]

@miq-bot add_label bug, gaprindashvili/yes
@miq-bot assign @himdel
@skateman this should resolve your issue.

[miq-bot]

Checked commit karelhala@74d1445 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

[skateman]

[himdel]

Makes sense, Promise.resolve fixes it and we do have it shimmed for older browsers 👍

[simaishi]

@karelhala Please add BZ link.

[karelhala]

@simaishi I don't think this has BZ.

[simaishi]

@karelhala Backport to z-stream requires a BZ!

[karelhala]

@simaishi oh I see, the problem is that #3192 fixed BZ, but introduced bug on some screens and this PR fixes that bug. So I guess linking https://bugzilla.redhat.com/show_bug.cgi?id=1530939 might be ok.

[simaishi]

@karelhala 5.9 clone of that BZ (https://bugzilla.redhat.com/show_bug.cgi?id=1533234) is already closed, so that can't be reused... Can you please create a new BZ for this PR?

[himdel]

Backport together with #3532 please.

[karelhala]

@simaishi sorry for the long delay, I thought this was resolved, but looks like we need to backport this to gaprindashvili as well, here is the coresponding BZ - https://bugzilla.redhat.com/show_bug.cgi?id=1596172