Fixed code to display dialog form buttons when loading old dialog runner #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transform screen still uses old dialog runner, fixed code to show form buttons on transform VMs screen. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540159
h-kataria
force-pushed
the
display_dialog_buttons_for_old_dialogs_on_trasform_screen
branch
from
95fb961
to
0364857
Compare
|
Checked commit h-kataria@0364857 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
eclarizio
approved these changes
Feb 1, 2018
simaishi
pushed a commit
that referenced
this pull request
Feb 1, 2018
…d_dialogs_on_trasform_screen Fixed code to display dialog form buttons when loading old dialog runner (cherry picked from commit bd38e87) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1541176
|
Gaprindashvili backport details: |
h-kataria
deleted the
display_dialog_buttons_for_old_dialogs_on_trasform_screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transform screen still uses old dialog runner, fixed code to show form buttons on transform VMs screen.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540159
@eclarizio please review/test, i have tried combinations of Settings.product.old_dialog_user_ui setting with old/new dialogs, seems to work for me.
before:
after:
