Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased username maxlength from 50 to 255 #3362

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Increased username maxlength from 50 to 255 #3362

merged 1 commit into from
Feb 2, 2018

Conversation

h-kataria
Copy link
Contributor

@miq-bot
Copy link
Member

miq-bot commented Feb 1, 2018

Checked commit h-kataria@462588c with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.5-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@dclarizio
Copy link

@gtanzillo requested a review just to see if you think this is the correct solution. Thx, Dan

gtanzillo
gtanzillo approved these changes Feb 2, 2018
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dclarizio dclarizio merged commit b8d18cc into ManageIQ:master Feb 2, 2018
@dclarizio dclarizio added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 2, 2018
simaishi pushed a commit that referenced this pull request Feb 2, 2018
@simaishi
Merge pull request #3362 from h-kataria/increase_username_maxlength
6461311 
Increased username maxlength from 50 to 255
(cherry picked from commit b8d18cc)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1541518
@simaishi
Copy link
Contributor

simaishi commented Feb 2, 2018

Gaprindashvili backport details:

$ git log -1
commit 64613112bb808376ab868ca1de3abe1f68c250f7
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Fri Feb 2 08:49:38 2018 -0800

    Merge pull request #3362 from h-kataria/increase_username_maxlength
    
    Increased username maxlength from 50 to 255
    (cherry picked from commit b8d18ccbffd253769443744a5d567897aca9c858)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1541518

@h-kataria h-kataria deleted the increase_username_maxlength branch March 14, 2018 20:18
@ZitaNemeckova ZitaNemeckova mentioned this pull request Mar 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@dclarizio dclarizio

Labels
blocker bug gaprindashvili/backported settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@h-kataria @miq-bot @dclarizio @simaishi @gtanzillo