Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a physical rack to the topology #3369

Merged
merged 1 commit into from
Apr 8, 2018

Conversation

felipedf
Copy link
Member

@felipedf felipedf commented Feb 2, 2018

This PR is able to:

  • add a Rack icon into topology graph

Depends on: ManageIQ/manageiq#16853 [ Merged ]
screenshot-localhost-3000-2018-01-30-14-57-42-756

@skateman
Copy link
Member

skateman commented Feb 7, 2018

@miq-bot assign @skateman

@miq-bot
Copy link
Member

miq-bot commented Feb 8, 2018

Checked commit felipedf@2ecde3a with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

@skateman
Copy link
Member

skateman commented Feb 8, 2018

Could you please explain this add_to_graph thing you're adding a little bit? I'm trying to understand why do we need it. Thanks.

@felipedf
Copy link
Member Author

felipedf commented Feb 8, 2018

Alright, the idea was to keep the DAG simple, so a parent can have many children but a child can only have a parent, this is regarding a physical infrastructure.

Was a requirement that once i try to access a a provider's physical servers provider.physical_servers
it would return me all physical servers in its infrastructure, even thought those servers are inside chassis inside a rack. That said, the topology wouldn't be pretty

122 children = entity.send(method) if entity.respond_to?(method)
This line inside topology_service.rb would be responsible execute something like provider.physical_server

@felipedf
Copy link
Member Author

felipedf commented Apr 5, 2018

ManageIQ/manageiq#16853 was merged

Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval
Nice job 👍

@martinpovolny martinpovolny added this to the Sprint 83 Ending Apr 9, 2018 milestone Apr 8, 2018
@martinpovolny martinpovolny merged commit f79613e into ManageIQ:master Apr 8, 2018
@felipedf felipedf deleted the add_rack_to_topology branch May 4, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants