-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Authentication Status to the information given on quadicon #3378
Conversation
@miq-bot add_label gaprindashvili/yes, bug |
175a44b
to
e3f4d8a
Compare
refactoring to appease miqbot minor refactoring minor refactoring
e3f4d8a
to
c6aea79
Compare
Checked commit nimrodshn@c6aea79 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 app/helpers/quadicon_helper.rb
|
@nimrodshn the BZ link you sent is invalid, could you please update it? |
@skateman thanks! fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding Authentication Status to the information given on quadicon (cherry picked from commit 27c3dd5) https://bugzilla.redhat.com/show_bug.cgi?id=1552882
Gaprindashvili backport details:
|
Currently when hovering over a quadicon in the providers screen it is somewhat confusing if the quad is showing an issue due to Authentication Status not "Valid". In this PR we add this information upon mouseover.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1537200
cc: @himdel