Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Authentication Status to the information given on quadicon #3378

Merged
merged 1 commit into from
Feb 7, 2018

Conversation

nimrodshn
Copy link
Contributor

@nimrodshn nimrodshn commented Feb 6, 2018

Currently when hovering over a quadicon in the providers screen it is somewhat confusing if the quad is showing an issue due to Authentication Status not "Valid". In this PR we add this information upon mouseover.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1537200

screenshot from 2018-02-06 14-33-26
cc: @himdel

@nimrodshn
Copy link
Contributor Author

@miq-bot add_label gaprindashvili/yes, bug

@nimrodshn nimrodshn force-pushed the adding_info_mouseover_quad branch 2 times, most recently from 175a44b to e3f4d8a Compare February 6, 2018 15:22
refactoring to appease miqbot

minor refactoring

minor refactoring
@miq-bot
Copy link
Member

miq-bot commented Feb 6, 2018

Checked commit nimrodshn@c6aea79 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 4 offenses detected

app/helpers/quadicon_helper.rb

@skateman
Copy link
Member

skateman commented Feb 7, 2018

@nimrodshn the BZ link you sent is invalid, could you please update it?

@nimrodshn
Copy link
Contributor Author

@skateman thanks! fixed.

Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@himdel himdel self-assigned this Feb 7, 2018
@himdel himdel added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 7, 2018
@himdel himdel merged commit 27c3dd5 into ManageIQ:master Feb 7, 2018
simaishi pushed a commit that referenced this pull request Mar 7, 2018
Adding Authentication Status to the information given on quadicon
(cherry picked from commit 27c3dd5)

https://bugzilla.redhat.com/show_bug.cgi?id=1552882
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit b08a20c3b951e6aaba89e969acc24ac45d8c74ef
Author: Martin Hradil <himdel@seznam.cz>
Date:   Wed Feb 7 14:03:24 2018 +0100

    Merge pull request #3378 from nimrodshn/adding_info_mouseover_quad
    
    Adding Authentication Status to the information given on quadicon
    (cherry picked from commit 27c3dd53afdae83f7c9d3f9bf7b3d8f890d03b34)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants