Fix title of the page to be updated when searching text in Datastores and other pages #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
hstastna
force-pushed
the
Title_search_text_Datastores_other_pages
branch
9 times, most recently
from
8e97bd1
to
942d5e0
Compare
hstastna
changed the title
hstastna
force-pushed
the
Title_search_text_Datastores_other_pages
branch
from
c9b9adb
to
bf05407
Compare
skateman
suggested changes
Feb 12, 2018
| @@ -356,6 +356,24 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe '#get_node_info' do | |||
| let(:search) { nil } | |||
| @@ -718,6 +718,24 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe '#get_node_info' do | |||
| let(:search) { nil } | |||
added 6 commits
February 12, 2018 12:59
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540613 Fix title of the page to be updated according to search text in Compute > > Infrastructure > Datastores page.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540613 Fix title of the page to be updated according to search text in Services > My Services page.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540613 Fix title of the page to be updated according to search text in Configuration > Management page.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540613 Fix title of the page to be updated according to search text in Control > Explorer page.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540613 Fix title of the page to be updated according to search text in Automation > Ansible Tower > Explorer screen.
hstastna
force-pushed
the
Title_search_text_Datastores_other_pages
branch
from
bf05407
to
6e47e7d
Compare
hstastna
force-pushed
the
Title_search_text_Datastores_other_pages
branch
from
6e47e7d
to
70a363d
Compare
hstastna
force-pushed
the
Title_search_text_Datastores_other_pages
branch
from
70a363d
to
ec932f1
Compare
|
@skateman Thanks for your review of my specs, now it should be ok ;) |
|
Checked commits hstastna/manageiq-ui-classic@c7488df~...ec932f1 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Mar 8, 2018
…ther_pages Fix title of the page to be updated when searching text in Datastores and other pages (cherry picked from commit 749c538) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552900
|
Gaprindashvili backport details: |
|
@miq-bot add_label test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540613
Fix title of the page to be updated according to search text in Compute > Infrastructure > Datastores page and in another pages.
Details (for Datastores):
The title of the page was not updated when searching text in Datastores, because it was not implemented in storage controller. In other pages, for example VMs, it is implemented in
get_node_infomethod (like this: https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/vm_common.rb#L1155). The title which was changed according to search text in Datastores page, is stored in@titlevariable, updated in application controller (here: https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/application_controller.rb#L1199), but this variable is used for title in other pages, not in Datastores (and also it was set to just "Datastores", and we need "All Datastores"). For Datastores we see the title in the page, which is stored in@right_cell_text, so I added the line for updating@right_cell_textaccording to what is in@search_textto storage controller, toget_node_infomethod (as it is in other controllers, where it works).Another note:
I've added the line for updating
@right_cell_textto controllers BEFORE the name of a filter is added to the title here https://github.com/ManageIQ/manageiq-ui-classic/pull/3385/files#diff-deaa0e49bde4dd95612b5e0b14568aa6R343 (if some filter is applied). The reason is "clear":vs this:
Done: fixing the title in
-- Compute > Infrastructure > Datastores
-- Services > My Services
-- Configuration > Management
-- Control > Explorer
-- Automation > Ansible Tower > Explorer
-- spec tests for all of the changes in all of the controllers
Before searching text in Datastores:
Before fixing title in Datastores:
After fixing title in Datastores:
