Custom button group - validate required fields before enabling buttons #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comes from ManageIQ/manageiq#6578, looks like all other errors are error_message
to catch the problem of buttons being enabled before the server knows about the inputs Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536670
|
Testing: right now, this has to be tested with diff --git a/app/views/shared/buttons/_group_form.html.haml b/app/views/shared/buttons/_group_form.html.haml
index f43fa0b30..4f04bc6cd 100644
--- a/app/views/shared/buttons/_group_form.html.haml
+++ b/app/views/shared/buttons/_group_form.html.haml
@@ -15,7 +15,7 @@
"data-miq_observe" => {:interval => '.5', :url => url}.to_json)
.input-group-addon
%label.checkbox-inline
- - display = @record.set_data.key?(:display) && @record.set_data[:display] == '1'
+ - display = @edit[:new][:display]
= check_box_tag("display", "1", display,
"data-miq_observe_checkbox" => {:url => url}.to_json)
= _('Display on Button')(because of #3383 (comment)) EDIT: fixed in #3431 |
|
@dclarizio Does this make sense as a fix for https://bugzilla.redhat.com/show_bug.cgi?id=1536670 ? |
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/6af4e3189ceb979d48602680978b19bc483225a2~...3a7e8715729abf0719294c89fa4febc6a3a75572 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Mar 8, 2018
Custom button group - validate required fields before enabling buttons (cherry picked from commit 873ebff) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553244
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automation > Automate > Customization, Buttons accordion, select object type, Configuration > Add Button Group
Right now, it's apparently possible to submit the form before all the input changes made it to the server.
This enables server-side validation for the required fields.
Fixing this properly will probably mean an angular/react rewrite of the screen.
(+ a fix for the error message when it goes wrong :))
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536670