Fix Bottlenecks timeline no data message #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit GregP@f8da544 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@h-kataria Ready for review. |
simaishi
pushed a commit
that referenced
this pull request
Mar 8, 2018
Fix Bottlenecks timeline no data message (cherry picked from commit 9e9ba41) https://bugzilla.redhat.com/show_bug.cgi?id=1553288
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Bottlenecks timeline data not available message display from warning to information.
Note: Originating BZ request states that an error message, in red, is being displayed. The message and background appear to be "reddish", but in fact are "yellow" per Patternfly use and definition. Message itself has been refactored to be an info type to alleviate any visual confusion.
https://bugzilla.redhat.com/show_bug.cgi?id=1540695
Screen shot prior to fix:
Screen shot post code fix, note Info message display:
