Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tagging component #3570

Merged
merged 27 commits into from
Mar 27, 2019
Merged

Add tagging component #3570

merged 27 commits into from
Mar 27, 2019

Conversation

PanSpagetka
Copy link
Contributor

@PanSpagetka PanSpagetka commented Mar 12, 2018 •
edited
Loading

Add tagging component to ManageIQ.

Links [Optional]

Steps for Testing/QA [Optional]

run bin/webpack in manageiq-ui-classic

Select some entity(Host/VM/...) -> Policy -> Edit tags
Select multiple entities on list view screen -> Policy -> Edit tags
Try it for Service/OrchestationTemplates/Tenants

@karelhala

@PanSpagetka
Copy link
Contributor Author

@miq-bot add_label WIP

@miq-bot miq-bot added the wip label Mar 12, 2018
@miq-bot
Copy link
Member

miq-bot commented Mar 13, 2018

This pull request is not mergeable. Please rebase and repush.

@PanSpagetka PanSpagetka force-pushed the add-tagging-component branch 3 times, most recently from 759c229 to 9223aea Compare March 26, 2018 12:18
@PanSpagetka PanSpagetka force-pushed the add-tagging-component branch 3 times, most recently from d76ac88 to 09f3d3f Compare April 5, 2018 10:06
@miq-bot
Copy link
Member

miq-bot commented Apr 5, 2018

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Jun 12, 2018

This pull request is not mergeable. Please rebase and repush.

@PanSpagetka PanSpagetka force-pushed the add-tagging-component branch 2 times, most recently from 8b71404 to 9298929 Compare June 27, 2018 09:36
@PanSpagetka PanSpagetka force-pushed the add-tagging-component branch 5 times, most recently from ca21366 to 6c17889 Compare June 27, 2018 10:50
@PanSpagetka
Copy link
Contributor Author

@miq-bot add_label react

@miq-bot miq-bot added the react label Jun 27, 2018
@PanSpagetka PanSpagetka force-pushed the add-tagging-component branch 2 times, most recently from 50f789e to 6be6de8 Compare June 27, 2018 11:05
@PanSpagetka
Copy link
Contributor Author

@Hyperkid123 $.post cannot be replaced with http.post because of the way how we process requests in miq_explorer.js

@miq-bot
Copy link
Member

miq-bot commented Mar 27, 2019

Checked commits PanSpagetka/manageiq-ui-classic@ce62fed~...c6e0bce with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
30 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

skateman
skateman approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@skateman
Copy link
Member

@martinpovolny @mzazrivec @himdel this looks fine now, can we get it in?

@mzazrivec
Copy link
Contributor

OK, merging ...
nuclear-blast

@mzazrivec mzazrivec self-assigned this Mar 27, 2019
@mzazrivec mzazrivec added this to the Sprint 108 Ending Apr 1, 2019 milestone Mar 27, 2019
@mzazrivec mzazrivec merged commit 564a772 into ManageIQ:master Mar 27, 2019
@PanSpagetka PanSpagetka mentioned this pull request May 2, 2019
Closed
@ZitaNemeckova ZitaNemeckova mentioned this pull request Jul 8, 2019
Merged
@himdel himdel mentioned this pull request Mar 6, 2020
Merged
@jrafanie jrafanie mentioned this pull request Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyperkid123 Hyperkid123 Hyperkid123 approved these changes

@skateman skateman skateman approved these changes

@romanblanco romanblanco Awaiting requested review from romanblanco

Assignees

@mzazrivec mzazrivec

Labels
react tagging technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@PanSpagetka @miq-bot @ZitaNemeckova @skateman @Hyperkid123 @rvsia @mzazrivec @h-kataria