Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support single quad for Network Provider quadicons #3628

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Support single quad for Network Provider quadicons #3628

merged 1 commit into from
Mar 19, 2018

Conversation

skateman
Copy link
Member

Analogous with #3624, adding optional single view for network provider icons.

screenshot from 2018-03-15 13-32-43

screenshot from 2018-03-15 13-33-24

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1556883

@miq-bot add_label bug, gaprindashvili/yes, gtls

@miq-bot
Copy link
Member

miq-bot commented Mar 15, 2018

Checked commit skateman@c42ebdc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@mzazrivec mzazrivec self-assigned this Mar 19, 2018
@mzazrivec mzazrivec added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 19, 2018
@mzazrivec mzazrivec merged commit 2bdc6fb into ManageIQ:master Mar 19, 2018
@skateman skateman deleted the ems-network-single-quad branch March 19, 2018 10:28
simaishi pushed a commit that referenced this pull request Mar 19, 2018
@mzazrivec @simaishi
Merge pull request #3628 from skateman/ems-network-single-quad
ab10c7b 
Support single quad for Network Provider quadicons
(cherry picked from commit 2bdc6fb)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1558142
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit ab10c7bbd0dac48527792653a3eadc3243469a75
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Mar 19 09:49:41 2018 +0100

    Merge pull request #3628 from skateman/ems-network-single-quad
    
    Support single quad for Network Provider quadicons
    (cherry picked from commit 2bdc6fb19f4e12bc8a6d504a8e5d06fb94ae3871)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1558142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug gaprindashvili/backported gtls settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skateman @miq-bot @simaishi @mzazrivec