Fix mismatching categories with values when assigning tags #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 19, 2018 11:24
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1556984 Fix sorting of categories by description for assigning tags so that downcase method is added, to sort items of the array properly.
Fix setting @edit[:cat] to first category when assigning tags so that 'min_by' method is replaced by 'first' method, to really get the first item of the categories' array.
Remove sorting of the array with categories for assigning tags from haml as it no longer makes sense to be there because proper sorting is already implemented in tag_edit_build_screen method.
|
@miq-bot add_label bug |
|
Checked commits hstastna/manageiq-ui-classic@02bc49c~...de0f009 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
hstastna
changed the title
|
@miq-bot remove_label wip |
|
Tested in UI. LGTM 👍Nice fix 👍 |
|
LGTM, hashes should follow insertion order in ruby 1.9+ so we can do this 👍 |
|
@miq-bot add_label gaprindashvili/yes |
simaishi
pushed a commit
that referenced
this pull request
Mar 27, 2018
Fix mismatching categories with values when assigning tags (cherry picked from commit 392d5f3) https://bugzilla.redhat.com/show_bug.cgi?id=1561096
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1556984
Partially caused by:
[1] ManageIQ/manageiq#5598
[2] ManageIQ/manageiq#9234
Done:
:descriptionfor assigning tags so thatdowncasemethod is added, to sort items of the array properly (not sorting only right before displaying the categories like in [2] because for example@edit[:cat]depends on what is in the first position of the array for categories, like here: https://github.com/ManageIQ/manageiq-ui-classic/pull/3644/files#diff-32a1920bfa43ecfb0853173babda0f8aL218)@edit[:cat]to first category so thatmin_bymethod is replaced byfirstmethod, to really get the first item of the categories' array (see the comment: https://github.com/ManageIQ/manageiq-ui-classic/pull/3644/files#diff-32a1920bfa43ecfb0853173babda0f8aR217;min_bydoes not always return what we expect, we simply need the first item of the array)tag_edit_build_screenmethod (see https://github.com/ManageIQ/manageiq-ui-classic/pull/3644/files#diff-32a1920bfa43ecfb0853173babda0f8aR196)Notes:
Before:
After:
