Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vault credential display for the playbook retirement tab #3684

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Add vault credential display for the playbook retirement tab #3684

merged 1 commit into from
Mar 27, 2018

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Mar 26, 2018 •
edited
Loading

Add vault credential display for the playbook retirement tab

Links [Optional]

https://bugzilla.redhat.com/show_bug.cgi?id=1561116

screenshot from 2018-03-26 17-20-20

@lgalis
Copy link
Contributor Author

lgalis commented Mar 26, 2018

@miq-bot add_label gaprindashvili/yes, automation/ansible, enhancement

@lgalis
Copy link
Contributor Author

lgalis commented Mar 26, 2018

@h-kataria - please review

@miq-bot
Copy link
Member

miq-bot commented Mar 26, 2018

Checked commit lgalis@a66695d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@mzazrivec mzazrivec self-assigned this Mar 27, 2018
@mzazrivec mzazrivec added this to the Sprint 83 Ending Apr 9, 2018 milestone Mar 27, 2018
@mzazrivec mzazrivec merged commit f6a992d into ManageIQ:master Mar 27, 2018
simaishi pushed a commit that referenced this pull request Mar 27, 2018
@mzazrivec @simaishi
Merge pull request #3684 from lgalis/add_vault_credentials_to_service…
1ff5321 
…_summary

Add vault credential display for the playbook retirement tab
(cherry picked from commit f6a992d)

https://bugzilla.redhat.com/show_bug.cgi?id=1559479
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 1ff532152753b4ad77e8edd4571c7fddf545a277
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Mar 27 09:51:02 2018 +0200

    Merge pull request #3684 from lgalis/add_vault_credentials_to_service_summary
    
    Add vault credential display for the playbook retirement tab
    (cherry picked from commit f6a992def5b43964b31042dc85b4523b439d1a79)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1559479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
automation/ansible enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lgalis @miq-bot @simaishi @mzazrivec