Fixed id of currentTab #3698
Merged
Fixed id of currentTab #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"metrics" tab id was renamed to container_metircs in ManageIQ#3511, this inconsistency was causing Validate button to remain disabled on openshift provider add/edit screen on Metrics tab. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1561180
|
Checked commit h-kataria@9a8f700 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@h-kataria #3511 is |
|
@simaishi you are right, i will fix the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"metrics" tab id was renamed to container_metircs in #3511, this inconsistency was causing Validate button to remain disabled on openshift provider add/edit screen on Metrics tab.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1561180
cc @masayag
@dclarizio please review.
before:
after:
