Skip re-validation when non-required fields are cleared #3705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug,gaprindashvili/yes |
|
Checked commits AparnaKarve/manageiq-ui-classic@a4e8ef1~...7e57d0b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@himdel, @ZitaNemeckova, @Hyperkid123 : can, please, one of you review this? I don't feel confident in this area. Thank you! |
|
looks good, verified fix in UI. |
|
Seems ok to me. Also i would have seriously consider using isolate scope in all directives. It should simplify the code and split controllers/components and the directive. But that is for another PR. see #2205 |
Hyperkid123
approved these changes
Apr 12, 2018
AparnaKarve
deleted the
bz1559957_skip_reset_validation_status_if_field_not_reqd
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip re-validation if fields that are not Required are blanked out.
This will fix the below BZ where the Save button is not enabled because a blanked out non-required field enforces re-validation.
Before (Save disabled, re-validation is enforced on a blank non-required field) -
After (Save enabled, re-validation is not enforced on a blank non-required field) -
https://bugzilla.redhat.com/show_bug.cgi?id=1559957