Remove 'Include C&U metrics' option for Metering Reports #3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533284 Remove 'Include C&U metrics' option for Metering Reports under Cloud Intel > Reports > Reports, for Metering for VMs, as this option is redundant, since, by definition, Metering Reports always include C&U metrics.
|
@miq-bot add_label bug |
Small change of the code for the section displayed when creating Chargeback/Metering report.
|
Checked commits hstastna/manageiq-ui-classic@be2c7f1~...5931fac with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533284
Remove 'Include C&U metrics' option for Metering Reports under Cloud Intel > Reports > Reports,
for Metering for VMs, as this option is redundant, since, by definition, Metering Reports always
include C&U metrics.
Before:
After:
Details:
I've added this line https://github.com/ManageIQ/manageiq-ui-classic/compare/master...hstastna:Remove_Include_C?expand=1#diff-1538215b565ccfdafec8a0d650ee5ebeR6 to the haml, as the option 'Include Capacity & Utilization Metrics' still makes sense, for
ChargebackVmmodel. The rest is untouched. This means that the second option under Chargeback Resources section is displayed also forMeteringVmmodel, normally.