Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Search from Switch summary page #3838

Merged
merged 1 commit into from
Apr 25, 2018

Conversation

hstastna
Copy link

@hstastna hstastna commented Apr 24, 2018

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1428584


Remove Search from Switch summary page accessed by clicking on some Switch from the list under Compute > Infra > Networking > Switches accordion.

Before:
switch_before

After:
switch_after

Details:
The BZ is fixed simply by hiding Search, in infra networking controller, when displaying the Switch details page and setting visibility of Search here: https://github.com/ManageIQ/manageiq-ui-classic/pull/3838/files#diff-0e2f6e9cd3d08a0294024651f1726172R576. And @nodetype is always set in get_node_info, before setting visibility of Search, according to type of the actual node in the tree.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1428584

Remove Search from Switch summary page accessed by clicking on some Switch
from the list under Compute > Infra > Networking > Switches accordion.
@hstastna
Copy link
Author

@miq-bot add_label bug, gaprindashvili/yes

@hstastna
Copy link
Author

@h-kataria @martinpovolny I have a question: does make any sense for @infra_networking_record to be there in https://github.com/ManageIQ/manageiq-ui-classic/pull/3838/files#diff-0e2f6e9cd3d08a0294024651f1726172L587 ? I have found no place where this variable could have been set. Thanks! :)

@miq-bot
Copy link
Member

miq-bot commented Apr 24, 2018

Checked commit hstastna@6b89006 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@mzazrivec mzazrivec self-assigned this Apr 25, 2018
@mzazrivec mzazrivec added this to the Sprint 85 Ending May 7, 2018 milestone Apr 25, 2018
@mzazrivec mzazrivec merged commit af30428 into ManageIQ:master Apr 25, 2018
@himdel
Copy link
Contributor

himdel commented Mar 6, 2019

does make any sense for @infra_networking_record

Looks like that was the bug, the code should say @record instead, and then the @nodetype condition is not needed.

(noticed during #5280)

@hstastna
Copy link
Author

hstastna commented Mar 7, 2019

Thank you very much, @himdel, for pointing this. I will fix it in the following PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants