bug 1570570: cloud volume create fixes #3878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1570570 There are two fixes here: 1) Error handling for cloud volume create/edit was broken. The controller was improperly handling the return value from the validate method calls. 2) The UI for showing the cloud tenant selection input wasn't handling the recent classname change for CinderManager
|
Checked commit sseago@c552bb4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
|
LGTM |
|
👍 |
h-kataria
approved these changes
May 7, 2018
simaishi
pushed a commit
that referenced
this pull request
May 16, 2018
bug 1570570: cloud volume create fixes (cherry picked from commit 5624822) https://bugzilla.redhat.com/show_bug.cgi?id=1578964
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1570570
There are two fixes here:
was improperly handling the return value from the validate method calls.
the recent classname change for CinderManager