Do not force exp_key to be limited to "CONTAINS" for date type fields. #3879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When selected field type id date type field, allow a drop down to be displayed with After/Before etc. options to be selected to form an expression. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1563823
|
Checked commit h-kataria@829af29 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/controllers/application_controller/filter/expression.rb
|
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Jan 21, 2019
Previous change was still forcing exp_key to be limited to "CONTAINS" for date type fields when switching fields because value of `self[:val1][:type]` is updated after changed code block in `prefill_val_types` method. Fixed a change made in ManageIQ#3879 with a call to backend method to return the type of field based upon selected column Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1563823
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Jan 22, 2019
Previous change was still forcing exp_key to be limited to "CONTAINS" for date type fields when switching fields because value of `self[:val1][:type]` is updated after changed code block in `prefill_val_types` method. Fixed a change made in ManageIQ#3879 with a call to backend method to return the type of field based upon selected column Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1563823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selected field type id date type field, allow a drop down to be displayed with After/Before etc. options to be selected to form an expression.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1563823
before:
after:
@yrudman cc
@dclarizio please review