Validate Help->Documentation screen against the documentation feature #3882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@b1a79fa with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Looks good this time ;-) |
simaishi
pushed a commit
that referenced
this pull request
May 7, 2018
Validate Help->Documentation screen against the documentation feature (cherry picked from commit 2b4ec4c) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1569171 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1575714
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
May 14, 2018
Validate Help->Documentation screen against the documentation feature (cherry picked from commit 2b4ec4c) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1569170 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1575713
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The naming of methods/actions inside this controller (its name included) is just horrible and misleading. The RBAC check was improperly introduced in #3728 against the
supportfeature, but it should bedocumentation.@miq-bot add_reviewer @romanblanco
@miq-bot add_reviewer @martinpovolny
ping @simaishi
@miq-bot add_label bug, gaprindashvili/yes, fine/yes
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1563241
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1573996