Display what is being edited in the report menu editor #3900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@d236b76 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@skateman change looks good, just curious there was no way to highlight the node in the tree? |
|
@h-kataria well, if it would be that easy :( it's totally undeterministic. For certain node types it doesn't reloads the tree so the selection stays, but for others it reloads and the selection is gone. |
|
@h-kataria is this one good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing folders in a report menu editor, the tree node is being unselected and so it's not clear what is being edited. With this change this will be displayed on the right side, see the screenshots.
Before:
After:
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1550641
@miq-bot add_label bug, gaprindashvili/yes
@miq-bot assign @h-kataria