Dashboard services - add missing rbac

[himdel]

All the dashboard services have missing RBAC now:

ContainerProjectDashboard does:

  def initialize(project_id, controller)
     @project_id = project_id
     @project = ContainerProject.find(@project_id)

and is initialized from ContainerDashboardController like...

  def collect_project_data(project_id)
    ContainerProjectDashboardService.new(project_id, self).all_data
  end

called as

  def project_data
    render :json => {:data => collect_project_data(params[:id]) }
  end

(project_data being the endpoint).

Similar thing happens in the other dashboard service/controller pairs.

Fixing that :)

The change is just
:s/\([A-Z][a-zA-Z:]\+\).find(\([^)]*\))/find_record_with_rbac(\1, \2)

Thanks @skateman, @felipedf for noticing.

[skateman]

[mzazrivec]

@himdel The CI failures seem related:

undefined method 'find_record_with_rbac' for #<ContainerDashboardService

[himdel]

Aah thanks, forgot to include the mixin :)

Added.

[felipedf]

@himdel CheckedIdMixin is defined inside the Mixins module so you might wanna do include Mixins::CheckedIdMixin instead.
Also is there any convention/rule that prevent us from including this on the super class DashboardService that I am not aware of? pure curiosity 😄

[himdel]

@fbladilo Thanks for noticing, fixed :)

Also is there any convention/rule that prevent us from including this on the super class DashboardService that I am not aware of? pure curiosity smile

Well, DashboardService is not the class using it. So we can add it somewhere which will not use it and rely on other code inheriting from there .. or we can add it to the places actually using it, reducing confusion and the burden for future refactoring :). But you're right, there's no technical reason this would not work on DashboardService now.

[miq-bot]

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/2a67164f151d5acc4d2d4c4bdcd34d48107b0637~...d020a346eacce2dcb56d37e314e488783c099b38 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. ⭐