bz 1509244: Don't require form changes in order to submit backup restore #3911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1509244 The 'save' button in the backup restore form wasn't active until the user first selected a different volume. To restore to the current volume required changing to a different volume and then re-selecting the original. This commit removes the requirement to change the form first before submitting. Such a requirement makes sense for an edit form (no changes, no need to submit), but it does not make sense for an action form like this.
|
Checked commit sseago@34bddd8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1509244
The 'save' button in the backup restore form wasn't active until
the user first selected a different volume. To restore to the
current volume required changing to a different volume and then
re-selecting the original. This commit removes the requirement
to change the form first before submitting. Such a requirement
makes sense for an edit form (no changes, no need to submit),
but it does not make sense for an action form like this.