Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update switch ports relationship #3949

Merged

Conversation

saulotoledo
Copy link
Member

@saulotoledo saulotoledo commented May 16, 2018

The way we handle Switches ports has changed in the past weeks in the following PR:

ManageIQ/manageiq#17268

This code updates the UI to properly show Physical Network Ports.

@saulotoledo
Copy link
Member Author

saulotoledo commented May 16, 2018

@miq-bot add_reviewer @skateman

/cc @martinpovolny

@miq-bot miq-bot requested a review from skateman May 16, 2018 19:10
@miq-bot
Copy link
Member

miq-bot commented May 16, 2018

Checked commit saulotoledo@41ecd75 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@saulotoledo saulotoledo changed the title Update switches ports relationship Update switch ports relationship May 16, 2018
@martinpovolny
Copy link
Member

Restarting travis.

Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@martinpovolny martinpovolny merged commit 7cd08e4 into ManageIQ:master May 17, 2018
@martinpovolny martinpovolny self-assigned this May 17, 2018
@martinpovolny martinpovolny added this to the Sprint 86 Ending May 21, 2018 milestone May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants