page_title - don't require leading ": " in @page_title

[himdel]

Setting @page_title is a mechanism to provide custom <title> value.

For most of ops ui, this is computed from the current @layout, but that is not really pluggable and does not make sense for plugins.

So, we have @page_title and end up doing product_title + title - and calling it as productized_title(_(": Login")).

---

This updates productized_title to join the provided title with ": " automatically - so that we don't have to randomly @page_title = ": #{_('Migration')}" in v2v.

Instead, the line will be @page_title = _('Migration').

#3963: gaprindashvili yes because we need this for v2v to be able to use manageiq layouts instead of creating its own

Cc @mzazrivec , @martinpovolny

[miq-bot]

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/dd61f523966f62a871c0dc34ae135f5f770b16c8~...ebce29876f7b72926cc3517214d04db00abba84f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

[martinpovolny]

Do we want to i18n this string (the : basically), @mzazrivec ?

[mzazrivec]

I'd say no for now. We can fix this later, should that be a problem in some locales.

[martinpovolny]

@mzazrivec : are we getting updated translations for the Gaprindashvili releases? If not, we will need for this one.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit b4b293cd6d98755aff5293873fd5201378f3dc25
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Mon May 21 15:53:29 2018 +0200

    Merge pull request #3965 from himdel/v2v-page-title
    
    page_title - don't require leading ": " in @page_title
    (cherry picked from commit 7eafd5522b3563d24518b6cc1ab531eeca58332f)