Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bz 1570570: Fix typo in earlier commit #4006

Merged
merged 1 commit into from
May 31, 2018
Merged

bz 1570570: Fix typo in earlier commit #4006

merged 1 commit into from
May 31, 2018

Conversation

sseago
Copy link
Contributor

@sseago sseago commented May 30, 2018

https://bugzilla.redhat.com/show_bug.cgi?id=1570570

Second PR for this bug, since the earlier fix had a typo
that didn't show up in local testing.

@sseago
bz 1570570: Fix typo in earlier commit
900ccc4 
https://bugzilla.redhat.com/show_bug.cgi?id=1570570

Second PR for this bug, since the earlier fix had a typo
that didn't show up in local testing.
@mansam
Copy link
Contributor

mansam commented May 30, 2018

LGTM

@miq-bot
Copy link
Member

miq-bot commented May 30, 2018

Checked commit sseago@900ccc4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@aufi
Copy link
Member

aufi commented May 31, 2018

👍

@mzazrivec mzazrivec self-assigned this May 31, 2018
@mzazrivec mzazrivec added this to the Sprint 87 Ending Jun 4, 2018 milestone May 31, 2018
@mzazrivec mzazrivec merged commit abb8ad4 into ManageIQ:master May 31, 2018
@JPrause
Copy link
Member

JPrause commented May 31, 2018

@miq-bot add_label blocker

simaishi pushed a commit that referenced this pull request Jun 1, 2018
@mzazrivec @simaishi
Merge pull request #4006 from sseago/bz1570570-2
bfa9d22 
bz 1570570: Fix typo in earlier commit
(cherry picked from commit abb8ad4)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1578964
@simaishi
Copy link
Contributor

simaishi commented Jun 1, 2018

Gaprindashvili backport details:

$ git log -1
commit bfa9d227ed9f803ff6a8fb1a3ad04301a5442810
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu May 31 16:01:04 2018 +0200

    Merge pull request #4006 from sseago/bz1570570-2
    
    bz 1570570: Fix typo in earlier commit
    (cherry picked from commit abb8ad45fd4f15f89aa646fb3c8d833c20f024cc)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1578964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
blocker bug gaprindashvili/backported storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sseago @mansam @miq-bot @aufi @JPrause @simaishi @mzazrivec