Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render notifications fetched from the API in the correct order #4010

Merged
merged 1 commit into from
May 31, 2018
Merged

Render notifications fetched from the API in the correct order #4010

merged 1 commit into from
May 31, 2018

Conversation

skateman
Copy link
Member

Somehow the ordering of the notifications was reversed when requesting old ones from the API, fixing it.

https://bugzilla.redhat.com/show_bug.cgi?id=1583821

@skateman
Copy link
Member Author

@miq-bot add_label bug, gaprindashvili/yes, fine/yes

@miq-bot
Copy link
Member

miq-bot commented May 31, 2018

Checked commit skateman@b7f7ad2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@skateman
Copy link
Member Author

@miq-bot assign @himdel

@himdel himdel closed this May 31, 2018
@himdel himdel reopened this May 31, 2018
@himdel himdel merged commit 0ee6528 into ManageIQ:master May 31, 2018
@himdel himdel added this to the Sprint 87 Ending Jun 4, 2018 milestone May 31, 2018
@skateman skateman deleted the notification-reorder branch May 31, 2018 19:07
simaishi pushed a commit that referenced this pull request Jun 5, 2018
@himdel @simaishi
Merge pull request #4010 from skateman/notification-reorder
b9c016e 
Render notifications fetched from the API in the correct order
(cherry picked from commit 0ee6528)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1586213
@simaishi
Copy link
Contributor

simaishi commented Jun 5, 2018

Gaprindashvili backport details:

$ git log -1
commit b9c016ec0eeb08c8675ead7ee8aa83651b77477e
Author: Martin Hradil <himdel@seznam.cz>
Date:   Thu May 31 19:27:14 2018 +0200

    Merge pull request #4010 from skateman/notification-reorder
    
    Render notifications fetched from the API in the correct order
    (cherry picked from commit 0ee6528b01b8d52934a108a7baa4be859ff4efcb)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1586213

simaishi pushed a commit that referenced this pull request Aug 14, 2018
@himdel @simaishi
Merge pull request #4010 from skateman/notification-reorder
0695b7d 
Render notifications fetched from the API in the correct order
(cherry picked from commit 0ee6528)

https://bugzilla.redhat.com/show_bug.cgi?id=1586214
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 0695b7d9fa929764663215590b9e3debda4310aa
Author: Martin Hradil <himdel@seznam.cz>
Date:   Thu May 31 19:27:14 2018 +0200

    Merge pull request #4010 from skateman/notification-reorder
    
    Render notifications fetched from the API in the correct order
    (cherry picked from commit 0ee6528b01b8d52934a108a7baa4be859ff4efcb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1586214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@himdel himdel

Labels
blocker bug fine/backported gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skateman @miq-bot @simaishi @himdel