Prefer fonticon for resource pool if it's not vapp #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwinchell
approved these changes
Jun 5, 2018
|
@miq-bot assign @h-kataria |
skateman
force-pushed
the
resource-pool-fonticon
branch
from
35a914b
to
83b476b
Compare
|
@miq-bot add_label wip |
miq-bot
changed the title
|
@miq-bot unassign @h-kataria |
|
@epwinchell unrecognized command 'unassign', ignoring... Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
|
@miq-bot assign @epwinchell |
skateman
force-pushed
the
resource-pool-fonticon
branch
from
83b476b
to
b1ac112
Compare
epwinchell
reviewed
Jun 14, 2018
| @@ -4,12 +4,13 @@ def self.fonticon | |||
| end | |||
|
|
|||
| def fileicon | |||
| vapp ? '100/vapp.png' : '100/resource_pool.png' | |||
| vapp ? '100/vapp.png' : nil | |||
| end | |||
There was a problem hiding this comment.
@skateman how about svg/vmware.svg ?
skateman
force-pushed
the
resource-pool-fonticon
branch
from
b1ac112
to
0326b9f
Compare
|
@skateman I approve |
skateman
changed the title
|
Checked commit skateman@0326b9f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
resource_pool.pngis obsolete, thepficon pficon-resource-poolfully replaces it, but I haven't found any alternative for thevapp.png.Parent issue: #4051
@miq-bot add_label gaprindashvili/no, graphics
@miq-bot add_reviewer @epwinchell