Use fonticon for unknown container registries in textual summaries #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
registry-unknown-fonticon
branch
from
88dacc8
to
7f5f4ee
Compare
|
Checked commit skateman@7f5f4ee with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
epwinchell
approved these changes
Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need for
container_image_registry_unknown.pngas there's a fonticon class with the same color and shape. Also thecontentCSS rule for the given class has been replaced with a SASS@extendso we don't have to look up the unicode values.Parent issue: #4051
@miq-bot add_reviewer @epwinchell
@miq-bot add_reviewer @martinpovolny
@miq-bot add_label textual summaries, graphics, gaprindashvili/no