Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fonticons for sorting items on the provisioning form #4118

Merged
merged 2 commits into from
Jun 12, 2018

Conversation

skateman
Copy link
Member

Go to Lifecycle -> Provision VMs under Virtual Machines, select a template (ideally not an RHV as it requires valid and working credentials) and go to the Environment tab. All the fields that have sortable tables are using these icons for the sortable column's identification.

The image references have been replaced with fa-angle-up and fa-angle-down accordingly and as the PNG files are not used everywhere, I'm removing them.

Parent issue: #4051

@miq-bot add_reviewer @epwinchell
@miq-bot add_label gaprindashvili/no, graphics

@miq-bot
Copy link
Member

miq-bot commented Jun 12, 2018

Checked commits skateman/manageiq-ui-classic@3954540~...b7a61d0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
10 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@h-kataria h-kataria self-assigned this Jun 12, 2018
@h-kataria h-kataria added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 12, 2018
@h-kataria h-kataria merged commit 0330529 into ManageIQ:master Jun 12, 2018
@skateman skateman deleted the provisioning-sort-icons branch June 12, 2018 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants