Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fonticons for embedded items in automate and catalogs #4129

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

skateman
Copy link
Member

There were 3 places where PNGs were used:

  • Editing a catalog bundle's resources
  • Editing a schema of an automate class
  • Editing the inputs of an builtin automate method

Parent issue: #4051

@miq-bot add_label gaprindashvili/no, graphics
@miq-bot add_reviewer @epwinchell

@miq-bot
Copy link
Member

miq-bot commented Jun 13, 2018

Checked commit skateman@5a3872d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@mzazrivec mzazrivec self-assigned this Jun 13, 2018
@mzazrivec mzazrivec added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 13, 2018
@mzazrivec mzazrivec merged commit 967a8a1 into ManageIQ:master Jun 13, 2018
@skateman skateman deleted the drop-16-icons branch June 13, 2018 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants