Fixing textual summary payload mount for multilabel components #4148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit douglasgabriel@7d16893 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label bug |
|
@douglasgabriel Cannot apply the following label because they are not recognized: bug textual summaries |
|
I have a WIP with this fix here: #4111 Thank you for the fix! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
#4147
Before this PR
The
TextualSummaryWrappersends this error while trying to process the payload:Warning: Failed prop type: The prop 'rows' is marked as required in 'SimpleTable', but its value is 'undefined'.After this PR
The
TextualMultilabelstruct sets the:rowsvalue using the:valuesThis approach was adopted to provider a compatibility with all summaries that uses the TextualMultilabel, but, another approach is to parse the
:rowsvalue with the value ofoptions[:rows], but this way we must update all the files that uses TextualMultilabel