Fix error on localized worker settings screen #4156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For worker memory threshold, we should be saving numbers, not translated strings (e.g. en: "500 MB" -> fr: "500 Mo") https://bugzilla.redhat.com/show_bug.cgi?id=1589122
|
Checked commit mzazrivec@271ab16 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Before: After: Tested in UI. LGTM 👍 |
himdel
modified the milestones:
Sprint 88 Ending Jun 18, 2018,
Sprint 89 Ending July 2, 2018
simaishi
pushed a commit
that referenced
this pull request
Jun 19, 2018
…ettings_screen Fix error on localized worker settings screen (cherry picked from commit 90bbf6f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1592913
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For worker memory threshold, we should be saving numbers, not translated strings (e.g. en: "500 MB" -> fr: "500 Mo")
Without this fix, you'd get an error. With this fix in place, the screen will be working correctly.
https://bugzilla.redhat.com/show_bug.cgi?id=1589122