-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to AnsibleTowerJobTemplateDialogService to support both job and workflow template. #4157
Conversation
808ddd6
to
ee1a3de
Compare
ee1a3de
to
c9fdbb6
Compare
@lfu Please remove the |
Does this need tests? |
@lfu Please review test failure. |
76a17f8
to
2d6e9c7
Compare
@miq-bot remove_label "pending core" |
@lfu Cannot remove the following label because they are not recognized: "pending core" |
@miq-bot remove_label pending core |
Please review. |
@lfu Please add screenshots of the before/after dialogs for JobTemplates and include the new dialog for Workflows to the description. @h-kataria Please review. |
@lfu looks like code is very similar in these methods |
Add service_name field so the dialog would have at least one tab. https://bugzilla.redhat.com/show_bug.cgi?id=1590975
2d6e9c7
to
c40c18c
Compare
Checked commit lfu@c40c18c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
The dialog code for Ansible Tower job template can be used for workflow template as well.
Add Service Name field in Options group so the dialog would have at least one box.
Limit option is supported only by Ansible Job Template. Ansible Workflow Template seems does not support it.
Depends on ManageIQ/manageiq-providers-ansible_tower#103.
https://bugzilla.redhat.com/show_bug.cgi?id=1590975
Before:
After:
New dialog for workflow job template: